Skip to content

🔥 remove long context test with bad config #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

🔥 remove long context test with bad config #391

merged 1 commit into from
Aug 18, 2025

Conversation

@joerunde
Copy link
Collaborator

@joerunde joerunde commented Aug 18, 2025

Description

This removes the test_continuous_batching_with_long_contexts test, which was not using the required tp=4 setting.
We're setting up different tests that are a bit more thorough for long contexts anyway, so I'd rather just remove this than spend time trying to fix it

Related Issues

@github-actions
Copy link

github-actions bot commented Aug 18, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

wallashss
wallashss approved these changes Aug 18, 2025
View reviewed changes
Copy link
Collaborator

@wallashss wallashss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@prashantgupta24 prashantgupta24 enabled auto-merge (squash) August 18, 2025 19:51
@github-actions github-actions bot added the ready label Aug 18, 2025
@prashantgupta24 prashantgupta24 merged commit 07ef65f into main Aug 18, 2025
18 of 24 checks passed
@prashantgupta24 prashantgupta24 deleted the remove-bad-test branch August 18, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallashss wallashss wallashss approved these changes

@prashantgupta24 prashantgupta24 prashantgupta24 approved these changes

@rafvasq rafvasq Awaiting requested review from rafvasq rafvasq is a code owner

@sducouedic sducouedic Awaiting requested review from sducouedic sducouedic is a code owner

Assignees

No one assigned

Labels

ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joerunde @wallashss @prashantgupta24